samuelwillyanto1 opened a new pull request, #8727: URL: https://github.com/apache/hop/pull/8727
[#8726](https://github.com/apache/hop/issues/8726) [Incorrect validation logic in check() for Closure Generator transform and Evaluate Table Content action](https://github.com/apache/hop/issues/8726) ### Description This PR fixes incorrect validation behavior reported during "Verify pipeline" and "Verify workflow" checks: 1. **`ClosureGeneratorMeta.check()`**: - Fixed inverted condition when checking parent ID and child ID fields in the incoming stream. Previously, it reported an error remark when fields existed (`!= null`) and OK when missing. Now correctly reports error remarks only when fields are missing (`== null`). - Added unit test `ClosureGeneratorMetaTest.testCheckReportsOkWhenFieldsExistAndErrorWhenMissing()`. 2. **`ActionEvalTableContent.check()`**: - Fixed property validation which erroneously checked the non-existent property `"WaitForSQL"` (copy-paste remnant). - Properly validates `"connection"`, and conditionally validates `"customSql"` (when `useCustomSql` is enabled) or `"tableName"` (when `useCustomSql` is false). - Added unit test `WorkflowActionEvalTableContentTest.testCheck()`. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
