vbhanuchander-lang commented on PR #8638: URL: https://github.com/apache/hop/pull/8638#issuecomment-5985378665
@mattcasters thanks for the careful review. Both points are fixed in d81db5d836 (details inline). @hansva on your two questions: **Should the environment win over hop-config?** For the flag itself it now does, the same as `HopResolvedSettings`. For the imported variables I kept the environment at the lowest precedence, so turning the flag on cannot change what any existing name resolves to. The cost is that it can only fill gaps, not override hop-config in an image, which you mentioned on the issue. I think that override is worth having, but probably not for the whole environment. **The `HOP_` prefix.** That fits the override case well. Names like `HOP_*` are deliberate, so a follow-up could import them by default and let them win over hop-config, while this flag stays opt-in for arbitrary names like `PROJECT_HOME_PATH`, which the issue asks for. I would rather keep that as a separate PR so this one does not change existing precedence, but I am happy to fold it in here if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
