mattcasters opened a new pull request, #8773: URL: https://github.com/apache/hop/pull/8773
Nightly build [2332](https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/2332/) stops in `hop-misc-git` because `PreCommitCheckTest` fails: a listener registered on `HopGuiFileBeforeCommit` is never called. The console line `Create widgets: no GUI toolbar items found for root: HopGui-Status-Toolbar` is written while `GitDisabledWidgetsTest` disables the git status-toolbar button. That test passes, and the same line is already in the log of build 2331. `PreCommitCheckTest` passes on its own. It fails when an earlier test in the same JVM has already constructed `ExtensionPointMap` and the UI-test harness then calls `HopEnvironment.reset()`. `PluginRegistry.reset()` drops the map's listener, so a plugin registered after the reset never reaches the map. Build 2332 ran `HopDiffTest` (loading a pipeline constructs the map) before that reset. Build 2331 ran it afterwards, which is why this showed up on the next nightly. `HopClientEnvironment.reset()` now puts that listener back and clears the stale map. fixes #8755 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
