samuelwillyanto1 opened a new issue, #8777: URL: https://github.com/apache/hop/issues/8777
### Apache Hop version? 2.20.0-SNAPSHOT ### Java version? 21 ### Operating system Windows ### What happened? ### Description 1. **False Positive Result on Error**: When Action Truncate tables encounters an error (such as when no database connection is selected, or a database connection fails to connect), it logs an error but still completes with result=[true]. Because nrErrors is 0 and never incremented in the catch block (updateErrors() was not called), nrErrors == 0 evaluates to true at the end of execute(), overwriting the error status and causing the workflow to report SUCCESS. 2. **Missing Schema Population in Dialog**: In ActionTruncateTablesDialog, clicking "Click here to return tables name list" only populates table names and leaves the Schema name column blank. For databases with multiple schemas, users have to manually type schema names. Additionally, clicking it when no connection is selected throws an unhandled error rather than showing a user-friendly dialog. 3. **Missing Workflow Verification for Tables**: The action did not implement the check(...) method to warn users during Verify Workflow (F7) when no tables are selected to truncate. ### Steps to Reproduce 1. Create a workflow and add a "Truncate tables" action. 2. Leave the "Connection" field empty and enter a table name in the table grid. 3. Run the workflow. 4. As shown in the screenshot, the action logs an error, but finishes with "result=[true]" and proceeds along the success hop. <img width="1175" height="710" alt="Image" src="https://github.com/user-attachments/assets/234f366a-ecf0-448b-b7d0-5ce34ff1a40f"; /> ### Expected Behavior - The action should call updateErrors() on connection or execution failures so result=[false] and nrErrors > 0. - The dialog should validate connection before fetching table names and populate both Table name and Schema name automatically. - Verify Workflow (F7) should warn when no tables are selected. ### Issue Priority Priority: 2 ### Issue Component Component: Actions, Component: Database, Component: Hop Gui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
