samuelwillyanto1 commented on PR #8778: URL: https://github.com/apache/hop/pull/8778#issuecomment-6074473037
Thanks for the review and explanation. I have updated the PR: 1. **Preserved skip behavior**: Kept the original skip behavior for blank/empty rows (`RowEmpty` and `ArgEmpty`) without failing the action or stopping remaining truncates, ensuring only actual connection and execution errors trigger failures. 2. **Added unit test**: Added `ActionTruncateTablesTest` to test `execute()` with a null connection and a non-existent database connection, verifying `result.getResult() == false` and `result.getNrErrors() > 0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
