bamaer commented on PR #8825: URL: https://github.com/apache/hop/pull/8825#issuecomment-6086418790
Thanks for the review, @mattcasters. All four points were valid; they are fixed in the latest commit. - **`sshTunnelPassphrase`**: when a rule reads a connection field, the password check now also looks at the database plugin's own settings (`getIDatabase()`), and names ending in `passphrase` count as secrets. A test checks that the value stays out of the finding. - **Broken pipeline hops**: `targetTransforms` no longer uses `findNextTransforms`. It walks the enabled hops itself and skips any hop whose `from` or `to` is null, so the valid targets still count. - **Broken workflow hops**: `targetActions` and action `errorHandling` skip hops with a null end and compare actions by identity instead of `ActionMeta.equals`. - **`isX` getters**: the fallback now also tries `is` + the capitalised name, so `sshTunnelEnabled` and other connection flags resolve. One more fix in the same area: settings that only one database type has, such as Oracle's `walletPassword`, are now read from the database plugin's settings before `DatabaseMeta`. They were reported as missing before, and fields marked `password = true` there stay hidden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
