mattcasters opened a new pull request, #8837: URL: https://github.com/apache/hop/pull/8837
Nightly integration build [2336](https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/2336/) fails `hop-tech-falkordb` in `FalkorDbIT.testVectorSearch` and `FalkorDbIT.testRelationshipVectorSearch`: ``` expected: <0.7808688094430303> but was: <0.780990362167358> ``` That is the cosine similarity of `[0.9, 0.1, 0]` and `[0.7, 0.7, 0]`. The dialect still converts FalkorDB's cosine distance with `1.0 - score`. Against `falkordb/falkordb:6.0.1` on this machine the same statements return `0.78086884388999`, inside the old `1e-4` tolerance. The Jenkins host returned a cosine `1.2e-4` away from the exact value. Ranking was already correct, and the euclidean score for these vectors stays more than `0.01` away, so the check now allows `1e-3`. `FalkorDbIT` passed locally: 9 tests, including both vector searches. fixes #8755 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
