bamaer commented on PR #8840: URL: https://github.com/apache/hop/pull/8840#issuecomment-6097170554
@mattcasters thanks for the review, all three points are addressed in 5f1044f: - **Default and `<think>` tags:** the code comments, both tooltips and both doc pages now say that Off and On keep the reasoning out of the answer, and that with Default the model and the Ollama version decide, so the answer can include `<think>` tags. Default does not strip tags, so existing output is unchanged. - **Flag on the schema request:** the new `StructuredExtractThinkingTest` sends the request built by `StructuredExtract.buildRequest()` / `responseFormatFor()` to a stub Ollama, and checks that `"think":false` / `"think":true` goes out together with the JSON schema `format`, and that Default sends no `think`. The 0006 description and the README now say that the integration test only checks the schema-valid output, not the flag. - **Stored value:** the provider now stores the code (`OFF`, `ON`, `DEFAULT`); the editor still shows the label. Variables and unrecognised values are stored as typed. Providers saved with the label load as the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
