leehaut opened a new issue, #8866:
URL: https://github.com/apache/hop/issues/8866
### Apache Hop version?
2.20.0-SNAPSHOT
### Java version?
open jdk 21
### Operating system
Windows
### What happened?
### Environment
- Component: Workflow action **Evaluate files metrics**
(`EVAL_FILES_METRICS`)
- Class: `plugins/actions/evalfilesmetrics/.../ActionEvalFilesMetrics.java`
- Method: `check(...)`
### Steps to reproduce
1. Create a workflow with one **Evaluate files metrics** action.
2. Set source to **files**, and add **two** file/folder rows (e.g.
`files/a.txt` and `files/b-1.txt` where the second path does not exist).
3. Run **Verify workflow** / Check.
4. (Optional) Run the workflow and compare with runtime behavior.
### Actual behavior (before fix)
- Check reports something like:
`unable to validate. Reason: arguments`
- The action no longer has an `arguments` field (metadata was moved to
`sourceFiles` / `SourceFile.sourceFileFolder`), so validation fails immediately
and returns early.
- Even if the property name were corrected but `(i++)` kept, only rows `0,
2, 4, ...` would be validated; row `1` would be skipped.
- Runtime correctly logs missing files, e.g.
`File/folder [.../b-1.txt] does not exist!`
while Check may show nothing useful.
### Expected behavior
- Check should validate `sourceFiles` and each
`sourceFiles[i].sourceFileFolder`.
- Every configured file/folder row should be checked (no double increment).
- When a configured path does not exist, Check should report an error for
that row (aligned with execute behavior for static file sources).
### Root cause
```java
// Broken pattern (simplified)
validate(this, "arguments", ...);
for (int i = 0; i < sourceFiles.size(); i++) {
validate(this, "arguments[" + (i++) + "]", ...); // wrong name + skip odd
rows
}
### Issue Priority
Priority: 3
### Issue Component
Component: Hop Gui, Component: Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
