bamaer opened a new issue, #8873:
URL: https://github.com/apache/hop/issues/8873
### What needs to happen?
The VFS File Explorer (#8503) is in 2.20.0-SNAPSHOT. Before it ships in a
release, it needs the fixes and additions below.
### Fixes
- [ ] **Permissions on Hop Web.** Creating, renaming, deleting, pasting and
copying files does not check `EXPLORER_WRITE`, so a read-only user can change
files on the server and on any named connection. Check permissions the same way
the File Explorer perspective does, and disable the actions to match.
- [ ] **Clipboard is shared between Hop Web sessions.** `VfsFileClipboard`
is static, so one user can paste or move another user's cut files. Keep one
clipboard per session. `VfsFileExplorers.ACTIVE` is also static and unused, so
it can be removed.
- [ ] **Overwrite deletes the target before copying.** If the copy fails or
is stopped, the original is lost. Pasting a folder over an existing one deletes
the existing folder and everything in it. Write to a temporary name and rename
it into place. For folders, merge or refuse.
- [ ] **One overwrite answer applies to everything.** The question is asked
once and does not name the file. Ask per item, with Replace / Skip / Apply to
all / Cancel.
- [ ] **Stop cancels every running operation**, including copies in other
tabs. Stop only the selected operation and clean up partly written files.
- [ ] **Expanding a folder cancels other listings in the tab.** The listing
that was running is dropped, and a folder expanded too quickly can be left with
an empty placeholder row. Track listings per folder.
- [ ] **Large folders freeze the UI.** Folders are listed in full and the
table is rebuilt on every filter keystroke. Use a virtual table, cap the
listing, and wait for a pause in typing before filtering.
- [ ] **Background threads have no limit and no timeout**, so a hung FTP or
SFTP server leaves threads behind.
- [ ] **Explore saves the connection without asking.** Ask first, or browse
using the values in the editor.
- [ ] **Path comparisons use plain text**, so `/path` and `file:///path` are
treated as different folders. Compare VFS file names instead.
- [ ] **No UI test for the explorer.** Add tests for overwrite, deleting the
folder being shown, Stop during a copy, and pasting several items when some are
refused.
### Additions for the first release
- [ ] Named VFS connections, and local roots or drives, listed in the left
panel
- [ ] Copy URI, or a `${PROJECT_HOME}`-relative path, to the system clipboard
- [ ] Keyboard shortcuts: Delete, Ctrl+C/X/V, Enter, Backspace or Alt+Up,
Ctrl+L
- [ ] Progress for copies and moves (bytes and items)
- [ ] Hop Web: real upload from and download to the browser. Rename the
current Download/Upload to "Copy to…", and don't start in the server's home
folder.
- [ ] Drag and drop within the explorer, from the operating system, and to
and from the File Explorer perspective
- [ ] Large folders: show the first N entries with "load more"
### Later
Search in subfolders, preview pane, restoring tabs after a restart, owner
and permissions for local files, auto-refresh, zip and unzip.
### Issue Priority
Priority: 2
### Issue Component
Component: Hop Gui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
