bamaer commented on PR #8901:
URL: https://github.com/apache/hop/pull/8901#issuecomment-6152125387
Thanks @mtalbi-kinaxis, converging these versions is a good idea. On main,
for example, `core` builds against api-common 2.53.0 while the client assembly
ships 2.41.0, and this PR fixes that.
**Blocker**
- `pom.xml:209` — The new root `<dependencyManagement>` is inherited by
every module and takes precedence over the `hop-libs` BOM and imported BOMs
such as Beam's GCP BOM. Several pinned versions are older than what main ships
today:
- jackson-core / jackson-databind 2.21.7 → 2.21.4 / 2.21.5 in the client
and plugins. This undoes #8720 / #8721, and later Jackson bumps in
`lib/pom.xml` would no longer take effect.
- google-auth-library 1.46.0 → 1.41.0 in the Google plugin, 1.42.1 →
1.41.0 in the client.
- api-common 2.62.0 → 2.55.2 in the Google and Beam plugins.
*Suggested fix:* drop the root block and pin these in `lib/pom.xml`,
reusing its properties (e.g. `${jackson.version}`), at or above the versions
main ships now. The Beam plugin imports `hop-libs` first, so those pins apply
there as well.
Verified: compared resolved dependency versions for all modules and the
packaged Google and Beam plugin zips between main and this PR; built core,
engine, Beam and Google with unit tests (all pass). No Google Cloud / Dataflow
integration tests run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
