leehaut opened a new pull request, #8908: URL: https://github.com/apache/hop/pull/8908
## Summary - `ActionCreateFolder.check()` validated the bean property `filename`, while the field is `folderName` (XML `foldername`). F7 therefore reported `Unable to validate. Reason: filename` even when Folder name was filled in. - The dialog stores an empty Folder name as `""`. `notNull` only rejects `null`, so a blank name passed validation. The check now uses `notBlank` and reports `folderName cannot be null or blank` for `null`, `""`, and whitespace. - Handwritten getters and setters are replaced with Lombok. `getRealFolderName()` still resolves variables. - Unit tests cover serialization, clone, variable resolution, check results, and the execute paths for a missing name, a new folder, an existing folder, a file occupying the path, and a parent that is not a directory. ## Test plan - [x] Open a Create folder action, fill in Folder name, and press F7. The result is `folderName is OK`, with no `Unable to validate. Reason: filename`. - [x] Clear Folder name and press F7. The result is `folderName cannot be null or blank`. - [x] Enter only spaces in Folder name and press F7. The same blank-name error is reported. - [x] Run the action with a path that does not exist and confirm the folder is created. - [x] Run it again with "Fail if folder exists" enabled and confirm the action fails. Clear that option and confirm the action succeeds. - [x] `./mvnw -pl plugins/actions/createfolder test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
