bamaer commented on PR #8913: URL: https://github.com/apache/hop/pull/8913#issuecomment-6175253695
@mattcasters, this was merged with the review items still open, and the first one blocks everything else. 102 of the test files are derived from Pentaho libformula: same class names and test cases, and 74 still carry libformula `@author` tags (e.g. [DateDifFunctionTest.java#L25](https://github.com/apache/hop/blob/4f228a4c2dc31bd706c59a19fa02f85c5a2ea145/plugins/transforms/openformula/src/test/java/org/apache/hop/openformula/function/datetime/DateDifFunctionTest.java#L25)). Most come from LGPL 2.1 releases; `DaysFunctionTest`, `UnicharFunctionTest` and `ATAN2FunctionTest` come from Pentaho's current BSL-licensed master. Neither can be in an ASF release. This needs to be reverted, and re-landed with fresh tests together with the DST, Timestamp and result-type fixes from the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
