mattcasters opened a new pull request, #8926:
URL: https://github.com/apache/hop/pull/8926
Reverts the squash merge of #8913 (`4f228a4c2d`).
The OpenFormula engine under `src/main` has no copied author tags and was
committed as a new implementation. The tests that came with it were the
existing Kettle formula test suite, not new tests:
- Class names match that suite (`LeftFunctionTest`, `Prd5174Test`,
`Prd5297Test`, and the rest).
- 74 test files still carry `@author` tags from that suite (Cedric Pronzato,
Thomas Morgner, and others).
- The cases match. `LeftFunctionTest` still expects `LEFT("Hello";2)` to be
`He`, `LEN(LEFT("xxx";-0.1))` to be the invalid-argument error, and
`LEN(LEFT("xxx";2^15-1))` to be `3`. The published suite has those same rows.
The donor commit that called the engine clean-room also said it "passes 100% of
the OpenFormula test suite", which is this suite, kept in place.
That test suite is LGPL 2.1 on the 9.4 line and Business Source License
after that. An ASF header on the file does not relicense the text. #8913 copied
those tests into Apache Hop.
This revert removes the transform, the engine, the Kettle import change, and
the tests until the tests are written fresh.
fixes #8907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
