leehaut opened a new pull request, #8939:
URL: https://github.com/apache/hop/pull/8939

   ## Summary
   - Delete result filenames no longer validates a `filename` property. The 
action only has wildcard options; the names come from the previous result, so 
Check reported `filename cannot be null` and chained `fileDoesNotExist` for a 
field the dialog does not have.
   - Copy/Move result filenames now checks `destinationFolder` with a not-blank 
validator when the action is Copy or Move. Delete skips that check, because it 
does not use a destination folder. Check no longer looks up `filename` or uses 
`fileDoesNotExist`.
   
   
   ## Test plan
   - [x] Open Delete result filenames and press F7. Check reports no `filename` 
or `fileDoesNotExist` remark.
   - [x] Open Copy/Move result filenames with Copy or Move and an empty 
destination folder. F7 reports `destinationFolder cannot be null or blank`.
   - [x] Set a destination folder and press F7. Check reports 
`destinationFolder is OK` and does not mention `filename`.
   - [x] Switch the action to Delete and press F7. Check does not require a 
destination folder.
   - [x] `ActionDeleteResultFilenamesTest` and 
`ActionCopyMoveResultFilenamesTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to