samuelwillyanto1 opened a new pull request, #8911:
URL: https://github.com/apache/hop/pull/8911
Fixes #8904
### Description
This PR fixes a false positive result in the workflow action **Columns exist
in a table** (`COLUMNS_EXIST`) and hardens the dialog:
1. **Fix False Positive:** Previously, when no columns were specified or the
list was empty, `nrexistcolums == columns.size()` evaluated `0 == 0 -> true`,
reporting success `(result=[true])` even when the database connection was
missing, empty, or failed. Updated condition to `!columns.isEmpty() &&
nrexistcolums == columns.size()`.
2. **Early Validation:** Validates `tableName` and `columns` before
attempting to open the database connection (`db.connect()`), avoiding
unnecessary connection overhead.
3. **Null-Safety:** Added null guards on `parentWorkflowMeta` and
`parentWorkflow` to prevent `NullPointerException`.
4. **Dialog Improvements (`ActionColumnsExistDialog`):**
- Fixed dead buttons: displays connection error dialog if `databaseMeta
== null` when clicking "Get columns" or browsing schemas.
- Applied `Comparator.nullsFirst(String.CASE_INSENSITIVE_ORDER)` to
safely handle schema-less database drivers (e.g. SQLite).
5. **Unit Tests:** Added 5 new unit tests covering missing connection,
non-existent connection, empty table name, empty columns, and check remarks.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
