bamaer commented on PR #8969: URL: https://github.com/apache/hop/pull/8969#issuecomment-6216929161
Thanks @Adalennis, this page was missing. I checked it against the engine and action code and it holds up, and all the xrefs resolve. Two things about *Execute for every result row* are worth adding: **Worth fixing** - **The loop stops at the first failed run** (`action-results.adoc:99`). Both actions only move to the next row while the error count is 0, so the remaining rows are skipped. Suggest: "If one of those runs fails, the loop stops, the remaining file names are not processed, and the result of the second action is false…" - **Rows passed on after a loop** (`action-results.adoc:60-61`). With *Execute for every result row*, both actions clear the rows before each run and give the child only the current row. Afterwards they pass on only what the last run left behind, usually just the last row, not the list they received. "A pipeline without one passes the rows it received on unchanged" only holds without the loop option. Suggest one sentence saying so. Docs only, so none of this can break anything. Reviewed against the code; site not built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
