bamaer commented on PR #8983: URL: https://github.com/apache/hop/pull/8983#issuecomment-6230793598
Thanks, the handling of hidden rows around sort/delete/paste is well covered by the tests. I built the PR (`ui`, `rcp`) and ran `TableViewColumnViewsTest`, `TableViewColumnViewManagerTest`, `TableViewColumnViewFilterTest`, plus the other `TableView*` / `ShowRowsDialog*` UI tests: all green. I also tried filter + sort + show all on 30k rows (apply 0.2 s, sort 1.3 s, restore 0.2 s), and `removeEmptyRows` with a filter on. Order and line numbers come back right. Not tested in Hop Web. RAP's `Table` allows the overrides, but I didn't run it. No blockers from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
