bamaer commented on PR #8987: URL: https://github.com/apache/hop/pull/8987#issuecomment-6235058347
Thanks @mattcasters. Built it and ran `BaseGuiWidgetsStaticListenerTest`, `MetaSelectionLineSubclassToolbarTest`, `MetaSelectionLineFillItemsTest` and the Neo4j `NeoConnectionSelectionLine*` tests: all green. Reverting either half of the fix makes `MetaSelectionLineSubclassToolbarTest` fail (missing edit icon, then the click logging "Unable to call method editMetadataElement"), so the test covers both. Also checked that the clear-DB-cache toolbar item and its filter still resolve the line. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
