Adalennis opened a new pull request, #8991: URL: https://github.com/apache/hop/pull/8991
Fixes #8976 The description check added in #2606 used `grep -L '^:description:'`, which also matches an empty `:description:` line, so these pages were not caught: - Empty descriptions filled in: Mail server connection, REST connection, End repeat, Pipeline action. - Descriptions copied from other pages replaced: Pipeline Data Probe (had PGP Encrypt Stream's), MongoDB QL (had the SQL action's), Execution Information perspective (had Execution Data Profile's). - The Salesforce connection, fields and settings fragments moved from `pipeline/transforms/` to `pages/snippets/salesforce/`, with the includes in the five Salesforce transform pages updated. They are no longer published as pages of their own, so they don't need the `(not used directly )` descriptions. - The "Check page descriptions" step now requires text after `:description:`, so an empty one fails the check too. - Salesforce Update showed the Settings heading twice: the page had its own above the included fragment, which starts with one. The page's copy is removed. - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
