Adalennis opened a new pull request, #9047:
URL: https://github.com/apache/hop/pull/9047

   Addresses #8970
   
   Third batch: a Result section on the Delete file, Create folder, Delete 
folders, Add filenames to result, Delete filenames from result and Unzip pages, 
in the same format as #9000 and #9024.
   
   Every row comes from a hop-run test against the current code (78 workflows: 
success conditions, result rows with one or two fields, the result files and 
rows of the previous action, post-processing after unzip, invalid regular 
expressions, missing and read-only files and folders). None of these actions 
keep the error count of the previous action: the engine resets it before each 
of them.
   
   Also fixed in the options tables:
   - Delete folders and Unzip: "Copy previous results to args" / "Get args from 
previous" take the paths from the result rows, not from the result files.
   - Unzip: the Source wildcard example said `te.\.zip` doesn't match 
`/folder/test.zip`; since #5943 the expression is also matched against the file 
name. Exclude wildcard had the description of Include wildcard.
   - Add filenames to result: there is no destination per line.
   - Labels aligned with Hop Gui (Include Subfolders, Clear result filenames, 
Wildcard (RegExp), Zip File name, Target Directory, If file exists, ...).
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to