beatum commented on PR #9059:
URL: https://github.com/apache/hop/pull/9059#issuecomment-6332001634
Thanks again for the detailed review and feedback. i have implemented all
three fixes in PipelineExecutor and updated the tests to lock in the expected
behavior.
#### Retry parameter handling
executeWithRetries() now always reuses the original attempt-0 parameter
values on retries.
Fixed the buffered-row fallback to preserve column positions (including null
values) and use row metadata conversion instead of Object.toString().
#### Variable refresh on retries
Retry attempts now refresh variables from the live parent variable scopes
and JVM properties instead of relying on the pipeline's copied snapshot.
Transform variables are also refreshed so inherited child parameters and
static values such as ${ACCESS_TOKEN} pick up updated values before each retry.
#### Test updates
Replaced the stub-based retry test with a real-path scenario that verifies
both retry attempts receive the original attempt-0 parameter list, including
correct null handling.
Added a test to verify row metadata conversion is used instead of raw
toString().
Strengthened the variable refresh tests to cover updated parent-scope values
and JVM property fallback behavior across retry attempts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
