bamaer commented on PR #9082:
URL: https://github.com/apache/hop/pull/9082#issuecomment-6333844649
Thanks for yet another great fix @leehaut! This covers all the cases from
#9041. I built the plugin and ran the unit tests: all 52 pass, and the 7 new
ones fail on main without the fix. I also tried nested wildcards inside list
elements, missing fields in one element and empty elements, and they all give
the expected rows. I didn't run the sample pipelines.
**Should fix**
- **A list of maps split over several YAML documents still stops after the
first document.** `- id: 1\n- id: 2\n---\n- id: 3\n- id: 4` gives rows 1 and 2
only. Plain lists already behave this way on main: once a list document is used
up, `getRow` returns an empty row, and `YamlInput` reads that as the end of the
file. A one-line change in `YamlReader.getRow` (`YamlReader.java:169`) fixes
both cases, and the existing tests still pass:
```java
if (row.length == 0 && (!isFinishedDocument() || documentIt.hasNext())) {
```
A test with two list-of-maps documents would cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
