bamaer commented on PR #9088: URL: https://github.com/apache/hop/pull/9088#issuecomment-6343843020
Thanks @AnKiT-GaRG2 for this one. The new sections match the code: the extensions, the file names without an extension, the message texts, the JSON error handling and the Markdown preview behaviour all check out. One change before merging. The intro now points to the file types table as the list, but the table leaves out three types that are registered on main: | Type | Files | Registered in | |---|---|---| | Excel | `*.xls`, `*.xlsx` | `ExcelFileType` | | Parquet | `*.parquet`, `*.parq` | `ParquetFileType` | | Archive | `*.zip`, `*.7z`, `*.gz`, `*.rar` | `ArchiveFileType` | Git Info, the Hop install spec editor and the raw text type can stay out, since they are special-purpose views and not general file types. Two smaller points: - The shortcuts use `SWT.MOD1`, which is Cmd on macOS. `shortcuts.adoc` writes both forms, for example "`Ctrl+F` (`Cmd+F` on macOS)". - "Addresses #9070" won't close the issue on merge. Use "Fixes #9070" if this PR covers all of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
