AnKiT-GaRG2 opened a new pull request, #9087:
URL: https://github.com/apache/hop/pull/9087
Please add a meaningful description for your change here
A variable such as `${PROJECT_HOME}` in inline code is read by Asciidoctor
as the attribute `{PROJECT_HOME}`, which produced 35 "skipping reference to
missing attribute" warnings in 27 pages. This writes them as
`+${PROJECT_HOME}+`, the form that 299 other places in the docs already use,
and removes the stray "(TODO)" at the end of the `IHopMetadataObjectFactory`
paragraph in `metadata-plugins.adoc`.
How I checked it: I ran Asciidoctor 2.0.26 with `attribute-missing=warn`
over all 787 pages before and after. Before there were 35 such warnings in the
pages listed in the issue. After there are none, apart from
`page-component-version`, which is an Antora attribute that Antora supplies at
build time and which is not part of this issue. I also rendered a few of the
changed pages and checked that the variables still show up literally, for
example `<code>${PROJECT_HOME}</code>`. I did not run the Antora site build or
`mvn clean install apache-rat:check`, since only `.adoc` files changed.
Addresses #9069
------------------------
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically. (not run, documentation-only change)
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
