bamaer commented on PR #9090: URL: https://github.com/apache/hop/pull/9090#issuecomment-6356956171
Thanks @mattcasters, good catch that `SELECT_CHILDREN` only copies one level. That is why `metadata/` arrived empty. Built the setup plugin from this branch and ran its unit tests (all pass). Also ran the config copy and project creation against the real install `config/` folder: the new default project gets the `local` pipeline and workflow run configurations plus `local-audit` and `first-last`. **Blockers** None. **Should fix** - `HopVfsFiles.copyTree` is used twice by setup: to copy `<install>/config` into the new config folder, and to copy the default-project template into `~/Documents/hop/default`. Copying all subfolders fixes the second one. The first one now also copies `projects/default` and `projects/samples` into the new config folder (for example `~/.local/share/hop/projects/...`). `hop-config.json` points at neither, so they are unused copies. Suggestion: copy all subfolders only for the project template (`ProjectRegistrationWriter.java:125`) and keep the one-level copy in `ConfigFolderSeeder.java:70`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
