vbhanuchander-lang opened a new pull request, #9101: URL: https://github.com/apache/hop/pull/9101
Closes #9049. Fixes the six result problems found while documenting these actions in #9047: 1. **Add filenames to result**: a result row with only one field threw a NullPointerException out of `execute()`. The wildcard is now read only when the row has a second field, so a one-field row takes all files of the folder, the same as an empty wildcard. 2. **Unzip, double count**: `unzipFile` already counts its own error before returning false, so `processOneFile` no longer counts it again. This covers both an invalid zip and a zip that can't be deleted after extraction, because the failed delete throws into the same catch. 3. **Unzip, Fail mode**: `takeThisFile()` is now only called for entries that pass the include and exclude wildcards. 4. **Delete file**: when `delete()` returns false the action is false with 1 error, and no longer logs "deleted". 5. **Create folder**: when a file exists with the folder name, the action is false whether or not *Fail if folder exists* is selected. 6. **Delete filenames from result**: the `file.exists()` check is removed, so a matching result file is removed even if it was deleted from disk earlier. The NOTEs from #9047 are removed and the result tables updated. ## Tests One new test per fix (8 in total) in the existing test classes, plus a new `ActionDeleteFileTest`. All 8 fail without the change and pass with it. All tests in the five modules pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
