Adalennis opened a new pull request, #9104: URL: https://github.com/apache/hop/pull/9104
Addresses #8970 Fourth batch: a Result section on the File compare, Compare folders, Folder is empty, Files exist, Check files locked and DOS to Unix pages, in the same format as the earlier batches. Every row comes from a hop-run test against the current code (73 workflows: missing, unreadable and read-only files and folders, files compared with folders, success conditions and how each kind of error counts for them, result rows with one, two and three fields or none, invalid regular expressions, what each wildcard is matched against, and the result files and rows of the previous action). Also fixed in the descriptions and options: - Folder is empty: subfolders don't make a folder non-empty, and Include subfolders looks for files inside them (it doesn't check whether there are subfolders). The wildcard is only used with Limit search to (RegExp). - DOS to Unix: Copy previous results to args takes the path, wildcard and conversion from the result rows, not the result files; each line has a conversion, not a destination; the wildcard is matched against the whole path of each file; Add filenames adds to the result files, not to a "workflow output stream". - Labels aligned with Hop Gui (Limit search to (RegExp), Wildcard (RegExp), Only Files / Only Folders, Nr files, ...). Behaviour found while testing, documented in a NOTE or in the Result table, to be reported as code issues: - Compare folders matches entries by name only, so with Include subfolders a folder with s1/x.txt and s2/x.txt is reported identical to one with s1/x.txt and s2/y.txt. - Folder is empty: an invalid regular expression in Wildcard stops the workflow (PatternSyntaxException outside the try), also when Limit search to is not selected. - DOS to Unix: a result row with fewer than three fields stops the workflow with a NullPointerException. - DOS to Unix matches the wildcard against the whole path of each file (file:///...), not its name, so a wildcard like sales\.txt matches nothing and the action is still true. - Check files locked: a result row with one field is logged as an error and nothing is checked, and the action is still true. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
