Adalennis opened a new pull request, #9111:
URL: https://github.com/apache/hop/pull/9111
Addresses #8970
Fifth batch: a Result section on the Wait for file, Process result
filenames, Write to file, Evaluate files metrics, XML well formed and DTD
validator pages, in the same format as the earlier batches.
Every row comes from a hop-run test against the current code (63 workflows:
timeouts and files that appear while waiting, copy, move and delete of result
files with existing destinations and missing files, success conditions at and
below their limit, the three source types of Evaluate files metrics, result
rows with one and two fields, what each wildcard is matched against, metrics
when an action stops early, and the result files and rows of the previous
action).
Also fixed in the descriptions and options:
- Wait for file: the File size check row ended with three sentences about
the timeout, moved to where they belong; Add filename to result adds to the
result files, not "result fields".
- Process result filenames: the action works on the result files of the
previous actions, not on "a number of files and/or folders".
- Write to file: it writes the text entered in the action (with variables),
not "text from a field".
- Evaluate files metrics: the three result field options had no description,
and "If value is equal to" was listed twice instead of "If value is different
from".
- XML well formed: Include subfolders, the Advanced tab text and the
Files/Folders row had been copied from Move files ("move", "destination"); Copy
previous results to args reads result rows; the wildcard is matched against the
whole path.
- DTD validator: the action needs XML_ALLOW_DOCTYPE_DECL=Y, which is N by
default, otherwise every file fails with "DOCTYPE is disallowed" (same in 2.19).
- Labels aligned with Hop Gui.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
