bamaer commented on PR #9114: URL: https://github.com/apache/hop/pull/9114#issuecomment-6461430696
Reviewed the code and built the PR on Linux: `HopWindowsLocalFileSystemTest` 4/4 pass, checkstyle and spotless clean. Not run on Windows. The `listStatus` override matches Hadoop 3.4.2 `RawLocalFileSystem.listStatus` apart from the `canRead` check, and `FileUtil.list` is the only unguarded `NativeIO.Windows` call left in the local file system (`create` and `mkdirs` already check `NativeIO.isAvailable()`). So this should cover the commit path. No blockers from my side. The Windows Spark File Output run in the test plan is the only open item. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
