rmannibucau commented on code in PR #8915:
URL: https://github.com/apache/hop/pull/8915#discussion_r4402951175
##########
assemblies/client/pom.xml:
##########
@@ -29,6 +29,11 @@
<name>Hop Client</name>
<properties>
+ <!-- hop-client is a release distribution artifact (staged to
dist.apache.org), so it
+ must be deployed like any other module despite the assemblies/
parent's
+ maven.deploy.skip=true, which only exists to keep the other
assembly zips
+ (web, plugins, static) out of Nexus/Maven Central. -->
+ <maven.deploy.skip>false</maven.deploy.skip>
Review Comment:
this one is fine since it is the assembly we target not the pom so no
regression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]