bamaer commented on PR #9132: URL: https://github.com/apache/hop/pull/9132#issuecomment-6478144971
Thanks @Adalennis, checked these against the code. All rows match except one; the XSD DOCTYPE fix and both XSLT notes are confirmed. **Worth fixing** - **Repeat, True row** (`repeat.adoc:91`): Repeat never sets its result to true. When the loop ends normally, it passes on the previous action's true/false result. I ran a JavaScript action returning `false`, then an unconditional hop to Repeat, whose child workflow runs End repeat. The loop ends after one run, and Repeat follows its **red** hop (false, 0 errors). With `true` in the JavaScript action it follows the green hop. Suggested fix: add to the True row "...and the previous action was true", plus a NOTE like the one at line 97: after a false previous action (reached through an unconditional or red hop) the result stays false, even when the loop ended normally. Reviewed against the code; Repeat checked with hop-run, docs site not built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
