Adalennis opened a new pull request, #9149: URL: https://github.com/apache/hop/pull/9149
Addresses #8970 Tenth batch: a Result section on the pages of Get a file with FTP, FTP delete, Put a file with FTP, Put a file with SFTP and HTTP. Every row comes from a hop-run test against the current code (96 workflows: vsftpd and OpenSSH in Docker with their folders mounted on the host, and a local HTTP server for 200, 302, 401, 404, 500 and uploads; files reset before each test). Each action was also run after an action that is true with 2 errors (all pass on 0 errors), and with a previous result holding files and rows, on success and on failure. What the tests show: - Timeout in the three FTP actions is in milliseconds, not seconds: the value goes to the FTP client's connect and default timeouts. Timeout 1 always fails, Timeout 10 fails at random with "Read timed out", Timeout 0 or 30000 works. The pages (and the dialog tooltip) said seconds. - Get a file with FTP removes or moves each file right after it is downloaded, not "only after all selected files have been successfully transferred" as the page said: with a.txt failing, b.txt was still removed from the server. - Nr errors less than (Get a file with FTP, FTP delete) is true when the number of errors equals the limit, and the download stops there. FTP delete without a wildcard is then true with 1 error. - Put a file with FTP with Don't overwrite files and Remove files after transferal deletes a local file that already exists on the server, although it was not uploaded. Documented as a WARNING. - HTTP opens the target file before it sends the request, so a 404 or 500 empties an existing target file (unless Append is checked). Documented as a WARNING. - HTTP with Run for every result row: a first row that succeeds and a second one that fails give true with 1 error; a first row that fails stops the action. No previous rows: false with 0 errors. - FTP delete: Files retrieved holds the number of deleted files, and keeps the previous action's value when the remote directory is empty or there are no previous rows to read. - Put a file with SFTP adds the sent files to the result only when After SFTP Put is Do nothing; missing files from the previous result rows are only logged. Also fixed: - FTP delete: removed the Connection type (FTPS) option, gone since #7885; FTPS is now the Security option of an FTP connection. Descriptions for Copy previous results to args and Wildcard. - HTTP: the General tab table header had a missing quote (`width="90%, cols="1,3"`). - Get a file with FTP: what If file exists does with each choice; Add filename to result is checked by default. - Put a file with SFTP: Success when no file makes the action false, not the workflow. - Labels: FTP server name / IP address, Server port, Use active FTP connection, Move to folder, Create folder, Target directory, Specify Date time format, Add filename to result, Control encoding, Remove files after transferal, Server settings, SFTP server name / IP, Port, Action name, Name of action, Run for every result row, Append to specified target file, Add date and time to file name, Add filename to result filenames. Found while testing (not reported yet): the FTP timeout unit, the local file deleted by Put a file with FTP, the target file emptied by HTTP on an error status, HTTP being true with 1 error over several rows, and Nr errors less than accepting errors equal to the limit. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
