bamaer commented on PR #9139: URL: https://github.com/apache/hop/pull/9139#issuecomment-6491098083
Thanks @Adalennis. I checked every Result row and NOTE against the action code on main, and they match. I also ran the empty SQL script case on H2: it's true, as documented. **Worth fixing** - `waitforsql.adoc`, the first NOTE: "keeps checking until *Maximum timeout*". The default Maximum timeout is 0, which means it never times out (`DEFAULT_MAXIMUM_TIMEOUT = "0"` in `ActionWaitForSql`). With the default, a query on a missing table makes the action wait forever. Suggest adding: "With the default *Maximum timeout* of 0, it keeps checking forever." **Minor** - The False rows in `evaluatetablecontent.adoc` and `waitforsql.adoc` don't mention an empty connection. Wait for SQL's row also leaves out a connection that doesn't exist in the project. Both cases give false with 1 error, the same as "can't be opened". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
