bamaer commented on PR #9141: URL: https://github.com/apache/hop/pull/9141#issuecomment-6515695529
@mattcasters LGTM. Built `ui` on the PR head and ran the database perspective tests and `SwtUniversalImageTest`: 91 pass. Not run in Hop Web. One question, not blocking: on main, `runOperation` already caught and logged the rethrown SQL error on the background thread. So I don't think the stack trace itself ended the session. Hop Web registers no RAP exception handler, so an exception that escapes a UI callback ends the session, and `runSafely` now catches that. If you still have the servlet log from the crash, the exception in it would confirm this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
