bamaer commented on PR #9160: URL: https://github.com/apache/hop/pull/9160#issuecomment-6516680488
Code reviewed, built and tested locally: sftp and ssh plugin tests pass, checkstyle and spotless clean. Both new tests fail with the fix reverted. I reproduced #9159 against an embedded SSH server on a loaded machine. A command that answers immediately lost its stdout in 27 of 1000 runs on main and in 0 of 1000 with this PR. The SFTP proxy path was only checked through the unit test. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
