bamaer commented on PR #9164:
URL: https://github.com/apache/hop/pull/9164#issuecomment-6516882984
Thanks @hansva. I built the plugin from this branch and the unit tests pass.
I also timed it with `hop-run` at Basic level on 20,000 local files against
main: copy went from 2.41 s to 1.66 s, move from 1.80 s to 1.20 s and delete
from 1.43 s to 0.70 s. The log went from 20,015 lines to 117. I only read the
lineage-enabled path, I didn't run it.
**Should fix**
- With *Overwrite target file* on and targets that already exist, the
per-file `Copy will replace existing target file …` / `Move will replace
existing target file …` lines are still logged at Basic level without the
100-file limit. 20,000 existing targets still give 20,118 log lines and 2.50 s
(`ProcessFiles.java:370` and `:446`). The summary already reports how many
targets were replaced, so these lines can use the same limit as the per-file
line:
```java
data.filesOverwritten++;
if (isBasic() && data.basicFileLogLines < MAX_BASIC_FILE_LOG_LINES) {
```
With that change, copy and move each give 217 lines and run in about
1.5–1.65 s, and the tests still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
