bamaer commented on PR #9163: URL: https://github.com/apache/hop/pull/9163#issuecomment-6540149503
Built `engine` from this branch and ran the `Lineage*Test` classes: all pass. Removing the new guard in the `FileObject` overload makes the new test fail, so it does what it says. LGTM. Possible follow-up: callers still look up the file size and build content schemas before calling the emitter (`BaseFileInputTransform.emitLineageFileRead`, `ExcelInput`, `TextFileOutput.writtenFileContentSchema()`, ...). The new `isEnabled()` could skip that work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
