leehaut opened a new pull request, #9187: URL: https://github.com/apache/hop/pull/9187
Fix https://github.com/apache/hop/issues/9170 ## Summary - Fix Get a file with FTP and FTP delete so failures before any transfer (connection refused, login refused, missing remote directory, invalid/empty wildcard, etc.) always leave the action `false`, even when **Success on** is **Nr errors at most**. - Keep the existing `nrErrors <= limit` semantics (aligned with other file actions); rename the UI label and docs from "less than" to **at most** so wording matches behavior. - Avoid double-counting when FTP delete stops after the success condition is broken (Limit files = N and the Nth file fails). ## Details Previously, setup exceptions were counted with `updateErrors()` and then evaluated by `isSuccess()`. With **Nr errors at most** and Limit ≥ 1, a single connection/login/wildcard failure became `true` and followed the success hop. Success conditions now apply only after listing/matching is ready (`transferAttempted`). Setup failures no longer pass through `isSuccess()`. ## Test plan - [x] Unit: `ActionFtpExecutionTest` / `ActionFtpDeleteExecutionTest` — setup failures stay false with `SUCCESS_IF_ERRORS_LESS`; file-level errors equal to the limit stay true; delete no longer double-counts when the condition breaks - [x] Manual: connection refused + Limit 10 → `result=[false]` (Get and Delete) - [x] Manual: FTP delete with empty wildcard + Limit 10 → `result=[false]` - [x] Manual (optional): real FTP — Get with one file failure and Limit 1 → still true (at most) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
