bamaer opened a new pull request, #9192: URL: https://github.com/apache/hop/pull/9192
Fixes #9003 hop-run no longer gives a declared parameter the value of a same-named project, environment or hop-config variable. A parameter gets its `-p` value, or else its default, like in Hop Gui and for child executions since #8101. - `HopRunBase.configureParametersAndVariables`: removed the variable-to-parameter promotion. - http ITs: the `main-*.hwf` workflows no longer declare `HOSTNAME`/`CASTLEMOCK_HOSTNAME`, which come from the environment. - Working with parameters: hop-run section updated, with a note on the behaviour change. This needs a line in the 2.21.0 upgrade notes. Tested: full `clean install`; http ITs through `run-tests-docker.sh`, 53/53 in single-JVM and in per-test-JVM mode. The pre-change `main-0001` fails in per-test mode on this build, the updated one passes. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
