bamaer commented on PR #9193: URL: https://github.com/apache/hop/pull/9193#issuecomment-6555056291
Thanks @gvdutra, this fixes #9045. CI is green and the tests cover all four trim modes plus the JSON Input case. One side effect for the record: `Const.onlySpaces` uses `isSpace`, and `ValueMetaBase.convertDataFromString` checks `onlySpaces` before trimming, whatever the trim type. A value made only of non-breaking spaces now converts to the empty/null value even with trim type None. This matches the existing behaviour for regular spaces, so it is consistent, but it is a change for existing pipelines. Follow-up, in a new issue: add direct `ConstTest` coverage for `isSpace`, `trim`/`ltrim`/`rtrim` and `onlySpaces` with U+00A0, U+2007 and U+202F, including the only-NBSP case above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
