mattcasters opened a new pull request, #9203: URL: https://github.com/apache/hop/pull/9203
JSON Input cleared the source-field combo before it asked the previous transform for its fields. `CCombo.setItems` / `removeAll` also clear the text. When that lookup threw, for example because an upstream Table Input referenced a missing table, the configured name was never written back. OK then saved an empty source field. The lookup now runs first. On success the items are replaced and the configured name is written back, including a name that is not in the new list. On failure the name stays and the error dialog is shown once. `JsonInputSourceFieldDialogTest` covers both paths (2 tests, 0 failures) under an isolated display. addresses #5953 The same clear-before-lookup pattern in other transform dialogs is a follow-up on this issue. This pull request does not include that sweep, and it does not revive #8588. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
