mattcasters opened a new pull request, #9206: URL: https://github.com/apache/hop/pull/9206
The project, environment, and git menus in the status bar were anchored to the whole toolbar, six pixels below it. Windows top-aligns a popup to that point, so the menu drops below the window when the desktop continues underneath. On a maximized window that point falls in the taskbar, outside every monitor work area. SWT then scales it with the primary monitor's zoom, and a second monitor at a different scale places the menu away from the click. The same layout at 100% on both displays does not show the jump. The menus now open upward from the clicked button. The point passed to SWT stays on that button's monitor. Fixes #9176 ## How to test On Windows, with a second monitor at a different scale from the primary if you have one: - Click the project button and the environment button, with the window maximized and again with it restored. - The menu should grow upward from that button. Its bottom-left corner sits on the button's top-left. - Do the same for the git branch button. `PopupMenuPlacementTest` (6 tests) passed, and the ui, projects, and git modules compiled. This was not clicked through on Windows. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
