bamaer commented on PR #9186:
URL: https://github.com/apache/hop/pull/9186#issuecomment-6571179059
Thanks, all three are fixed.
1. **jsr310:** the plugin now ships `jackson-datatype-jsr310` 2.21.7, and
its pom overrides the `stage-plugin-lib` exclude list so the jar is copied.
Before this, `JavaTimeModule` only resolved because `hop-tech-google` puts
jsr310 2.18.3 into `lib/core`, so it worked in the default client but broke if
Google wasn't installed. I checked that the SDK's object mapper builds against
Jackson 2.21.7 with only the plugin's jars.
2. **Timeout:** `sendAndWait` now gets the time left in the provider
timeout, at least 1 ms. When the SDK times out, the user gets the timeout
message instead of "request failed". The outer wait still covers CLI start-up
and session creation.
3. **Null response:** a missing assistant message, or one with no data, now
raises a `HopException` ("GitHub Copilot returned no answer.").
I added unit tests for the remaining-time calculation and for an SDK timeout
being reported as a timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
