mattcasters opened a new pull request, #9228: URL: https://github.com/apache/hop/pull/9228
Quitting the Hop GUI printed "Serious error detected in the Hop GUI" and exited with an error. `Display.dispose()` still runs queued `asyncExec` updates after the editor tabs are gone. A pipeline graph update called `ExplorerPerspective.hasNavigationPreviousFile()`, which called `getItemCount()` on a tab folder that was already null. The explorer, metadata, and execution perspectives now report no navigation when the folder is missing or disposed. `HopGui.handleFileCapabilities()` returns when the shell is gone. Pipeline and workflow `updateGui()` runnables return once the shell or toolbar is disposed. The explorer skips a tree refresh when the tree is already disposed. `DisabledPerspectivesTest` and `ExecutionPerspectiveDisabledTest` passed: 12 tests, 0 failures. A full GUI quit was not clicked through. fixes #9227 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
