leehaut opened a new pull request, #9237: URL: https://github.com/apache/hop/pull/9237
Fix https://github.com/apache/hop/issues/9174 ## Summary Fixes the Action result issues reported in #9174 so configuration and I/O failures are handled as action results (`false` + error count) instead of aborting the workflow, and aligns XML well formed wildcard matching with other file actions. - **Process result filenames** / **Evaluate files metrics**: catch invalid regular expressions (`PatternSyntaxException`) and return `false` with 1 error instead of stopping the workflow with a serious error - **XML well formed**: tolerate result rows with only one field when *Copy previous results to args* is enabled (empty wildcard); match wildcards against the file basename, not the full VFS URI - **Wait for file**: on an unreadable path (e.g. `zip:` into a non-zip file), use `logError` and set `nrErrors=1` instead of a misleading Basic "to stop growing" message with 0 errors - Update the related user-manual Result/NOTE sections to match the fixed behaviour - Add/extend unit tests for each case ## Test plan - [x] Unit tests for the four actions (invalid wildcard, one-field result row, basename wildcard, bad zip path) - [x] Manual repro with local workflows: - [x] `#1` Process result filenames with Wildcard=`[` → false hop, no serious error - [x] `#2` Evaluate files metrics (Filenames result) with Wildcard=`[` → false hop, no serious error - [x] `#3` XML well formed + Copy previous results to args with a 1-field result row → no NPE, action completes - [x] `#4` XML well formed with Wildcard=`good\.xml` → file is checked (basename match) - [x] `#5` Wait for file with `zip:` path into a non-zip file → Error log + `nrErrors=1`, false hop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
