mattcasters commented on PR #9211: URL: https://github.com/apache/hop/pull/9211#issuecomment-6600810059
Good catch, thanks @hansva. Fixed in b94746b. The output directory is now split with Beam `FileSystems.matchNewResource()` when the scheme is registered, and on the last `/` otherwise, so `gs://` and `s3://` keep both slashes for `FileIO.write().to()` and `withTempDirectory()`. A `file://` URI is turned into the local path it names first, because Beam's local filesystem would otherwise resolve it against the working directory. *Create parent folder* now only runs for local paths and `file://`, since object stores have no real folders and it would need credentials on the submitting machine. New tests write a `file://` URI and read it back, and check the `gs://` and `s3://` split without touching a bucket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
