leehaut opened a new pull request, #9246: URL: https://github.com/apache/hop/pull/9246
Fix https://github.com/apache/hop/issues/9175 ## Summary - **Move files**: evaluate `Success when number of errors lesser than` with a strict `<` limit; stop early when the condition is broken; avoid double-counting errors on `Fail` and stop forcing a successful result when a move fails. - **Delete files**: fail the action on an invalid wildcard regex and on previous-result rows with fewer than two fields (path + mask). - **Zip file**: set the action result from zip / after-zip work instead of inheriting the previous result; fail on an empty source and when move-after-zip fails. - Update the Move / Delete / Zip action docs so Result semantics match the fixed behavior, and add unit tests for the result paths above. ## Test plan - [x] Unit tests: `ActionMoveFilesResultTest`, `ActionDeleteFilesResultTest`, `ActionZipFileResultTest` (+ related Move local assertions) - [x] Manual repro workflows for #9175 cases 1–6 after rebuild: - [x] Move: success-condition / early exit - [x] Move: Fail without double `updateErrors` - [x] Delete: invalid regex → false - [x] Delete: bad previous row → false - [x] Zip: fromPrevious success → true (not previous false) - [x] Zip: empty source → false - [x] Zip: failed move-after-zip → false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
