bamaer commented on PR #9258: URL: https://github.com/apache/hop/pull/9258#issuecomment-6636113363
LGTM. Built `core` from the PR head and ran `ValueMetaTrimConsistencyTest`, `ValueMetaTimestampTest`, `ValueMetaInternetAddressTest` and `ValueMetaBaseTest`: all pass. With the old trim loops put back, both new tests fail, so they cover the bug. Trimming now matches `ValueMetaBase` (non-breaking spaces included, via #9193). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
