sharanggupta opened a new pull request, #9271: URL: https://github.com/apache/hop/pull/9271
Under a Turkish default locale, `name.toLowerCase()` turns `ID` into `ıd`, so `validateBQFieldName` rejected valid BigQuery field names such as `ID` or `CUSTOMER_ID`, and `sanitizeJobName` replaced every `I` in a Beam job name with a dash (`ID Job` became `-d-job`). Both now use `Locale.ROOT`, with tests that run under `tr-TR`. The test's `needsException` helper also threw its `HopException` inside its own `catch (Exception)`, so its negative checks could never fail; it now uses `assertThrows`. ------------------------ - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
